Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICU versions of MonthName and DayName #3545

Closed
hawkfish opened this issue Apr 30, 2022 · 3 comments · Fixed by #7332
Closed

ICU versions of MonthName and DayName #3545

hawkfish opened this issue Apr 30, 2022 · 3 comments · Fixed by #7332
Assignees
@hawkfish
Labels
stale

Comments

@hawkfish
Copy link
Contributor

These would be special cases of a more generic icu_to_char(VARCHAR, TIMESTAMPTZ) function.
@hawkfish hawkfish self-assigned this Apr 30, 2022
@dylanscott dylanscott mentioned this issue May 2, 2023
Merged
@hawkfish hawkfish reopened this May 3, 2023
@hawkfish
Copy link
Contributor Author

hawkfish commented May 3, 2023

The issue here is returning locale-specific month names (e.g, Adar II, not Undecember).

hawkfish pushed a commit to hawkfish/duckdb that referenced this issue May 3, 2023
Issue duckdb#3545: Fix Adar2 Crash
0c3dbe8 
Need to check for 13th month!
hawkfish pushed a commit to hawkfish/duckdb that referenced this issue May 3, 2023
Issue duckdb#3545: Fix Adar2 Crash
1357590 
Use the the correct Hebrew year
Mytherin added a commit that referenced this issue May 4, 2023
@Mytherin
Merge pull request #7346 from hawkfish/adar-2
dac8230 
Issue #3545: Fix Adar2 Crash
@github-actions
Copy link

github-actions bot commented Aug 2, 2023

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the stale label Aug 2, 2023
@github-actions
Copy link

github-actions bot commented Sep 1, 2023

This issue was closed because it has been stale for 30 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hawkfish hawkfish

Labels
stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add dayname/monthname functions for timestamptz type hex-inc/duckdb
1 participant
@hawkfish