Fix MSVC linking issue with workaround #10865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… than ours (14.39 vs 14.38)
|
Thanks! LGTM |
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Mar 15, 2024
Merge pull request duckdb/duckdb#10862 from Mytherin/batchinsertmemory Merge pull request duckdb/duckdb#10865 from samansmink/fix-mvsc-link-problem Merge pull request duckdb/duckdb#10860 from carlopi/build_fixes
carlopi
added a commit
to carlopi/duckdb
that referenced
this pull request
May 16, 2024
This requires some thoughs since this is very brittle, connected to duckdb#10865
carlopi
added a commit
to carlopi/duckdb
that referenced
this pull request
May 16, 2024
This requires some thoughts since specifiying version explicitly is very brittle\ Connected to duckdb#10865
carlopi
added a commit
to carlopi/duckdb
that referenced
this pull request
Jun 7, 2024
It seems to not be necessessary anymore
carlopi
added a commit
to carlopi/duckdb
that referenced
this pull request
Jun 7, 2024
It seems to not be necessary anymore
Mytherin
added a commit
that referenced
this pull request
Jun 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was an easy workaround thanks to the investigation done by the people at TileDB who ran into the same issue: TileDB-Inc/TileDB#4759.
this PR reenables the azure and aws extension where this link issue would trigger