Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix building issues in WIN32, remove unnecessary modification. #11356

Conversation

kindred77
Copy link
Contributor

Got some issues below when building on WIN10 with Microsoft Visual C++ 2017:

common/types/string_type.hpp:

error C2039: "min": is not a member of "std"

function/scalar/strftime_format.cpp

error C2039: "tolower": is not a member of "std"

function/scalar/compressed_materialization/compress_string.cpp

error C2219 syntax error : type qualifier must be after '*'
line 15 and line 21

Have removed the unnecessary modification from the prev one, see:
#11323

BTW, duckdb is awesome, thanks you all for sharing such great project.

@github-actions github-actions bot marked this pull request as draft March 26, 2024 19:39
@Mytherin Mytherin marked this pull request as ready for review March 26, 2024 19:39
@Mytherin
Copy link
Collaborator

Thanks - LGTM. I've just removed the #ifdef WIN32 as I think these changes are fine to apply in the general case.

@Mytherin Mytherin merged commit 9b8e5b6 into duckdb:main Mar 28, 2024
47 checks passed
@kindred77 kindred77 deleted the master-fix-build-issue-on-win32-remove-unnecessary-modification branch March 29, 2024 06:46
github-actions bot pushed a commit to duckdb/duckdb-r that referenced this pull request Mar 30, 2024
Merge pull request duckdb/duckdb#11356 from kindred77/master-fix-build-issue-on-win32-remove-unnecessary-modification
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants