Fix building issues in WIN32, remove unnecessary modification. #11356
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Got some issues below when building on WIN10 with Microsoft Visual C++ 2017:
common/types/string_type.hpp:
error C2039: "min": is not a member of "std"
function/scalar/strftime_format.cpp
error C2039: "tolower": is not a member of "std"
function/scalar/compressed_materialization/compress_string.cpp
error C2219 syntax error : type qualifier must be after '*'
line 15 and line 21
Have removed the unnecessary modification from the prev one, see:
#11323
BTW, duckdb is awesome, thanks you all for sharing such great project.