-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test dockerized compilation in Alpine:latest and Ubuntu:20.04 #11708
Conversation
Push for these tests is by @szarnyasg, adding in as reviewer. |
Also pinging @Flogex, since a PR of theirs (#11635) introduced the CMAKE_CURRENT_FUNCTION_LIST_DIR that is malfunctioning in the docker setup. I have yet to check on their setup, at Flogex/duckdb-extension-template@7aa87de, to double check whether this change might work for everyone. |
@carlopi Looks like Using |
Thanks! |
Unfortunately, this fix doesn't work in a conda environment, in the same way as described in #11640. It is enough to call |
I am happy to dig deeper, would it be possible for you to share instructions on how to reproduce your setup? Basically something in the form like:
where instead you provide how to install conda + how to fetch dependencies + what exact packages are needed ? Once I can reproduce, it should be easy(er) to find a way out plus have a way to test no regression will happen for relevant setups. |
Merge pull request duckdb/duckdb#11708 from carlopi/docker_builds Merge pull request duckdb/duckdb#11713 from carlopi/no_python_builds Merge pull request duckdb/duckdb#11701 from Mytherin/improvestatementreduction Merge pull request duckdb/duckdb#11700 from Mytherin/bumpjulia
Adding CI workflow for testing DuckDB compilation in dockerized environments.
Script currently provided for Alpine:latest and Ubunutu:20.04.
Those double down also as blueprints for how to compile and build DuckDB main binaries in those architectures / what dependencies are needed.
More tests are very welcome, it's a matter of adding a line per distribution to
scripts/test_docker_images.sh
.Adding a partial revert of #11663 where I propose a different fix to #11640 via providing a define, unsure whether this will be sufficient. Asking @zmbc if he could either provide a docker script showing the problem, I haven't managed to reproduce, and/or testing in its configuration with this alternative solution.
In the current form fixes #11703, otherwise merging only the first commit this should at the very least provide a reproduction and means to avoid similar regressions.