[COPY CSV] Enable TIMESTAMP_TZ formats #11711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Mytherin seems to be another (unrelated) http failure https://github.com/duckdb/duckdb/actions/runs/8736103221/job/23979737940?pr=11711 |
|
Thanks! |
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
May 1, 2024
Merge pull request duckdb/duckdb#11711 from Tishj/copy_csv_cast_rework
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #11660
Instead of hardcoding the conversion, we now use our existing Expression framework to use the Catalog to look up the right conversion.
Previously we always used the system StrfTime, but because we now use the Catalog, we can find the overload of
strftimeadded by the ICU extension (credit to Richard for the implementation idea)As shown by the tests, this does break some existing behavior.
If a TIMESTAMP is cast to TIMESTAMP_TZ and it is used in a COPY to csv with ICU not loaded (and not autoinstall/loadable) it will throw a binder error.