Decimal/Time implicit casting + Multi-Error store in Flush #11848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdet
commented
May 1, 2024
| TypeIdToString(parse_types[chunk_col_id].internal_type)); | ||
| } | ||
|
|
||
| } else if (decimal_separator == '.') { |
pdet
changed the title
|
Is this ready to be merged? :) I would love to test this before the next release hits. |
|
Thanks! |
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
May 16, 2024
Merge pull request duckdb/duckdb#11848 from pdet/implicit_cast_time_timestamp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds:
TIMEDECIMALTo types that are directly cast in both the sniffer and the scanner. This means that we don't have to go through
ValueorVectorto try cast functions. Allowing us to be faster and have much better error integrations.Much of the error-handling code has been rewritten to enable errors to persist until the result chunk is flushed. This approach allows us to accurately log flush casting errors in the reject tables when multiple errors occur on the same line.
Fix: #11832