Fix #12225: revert OVERWRITE_OR_IGNORE to previous behavior, move new behavior to OVERWRITE flag #12240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd add a new OVERWRITE option that fully removes the target directory
2 tasks
Tishj
reviewed
May 25, 2024
| @@ -39,7 +39,7 @@ unique_ptr<LogicalOperator> LogicalCopyToFile::Deserialize(Deserializer &deseria | |||
| auto file_path = deserializer.ReadProperty<string>(200, "file_path"); | |||
| auto use_tmp_file = deserializer.ReadProperty<bool>(201, "use_tmp_file"); | |||
| auto filename_pattern = deserializer.ReadProperty<FilenamePattern>(202, "filename_pattern"); | |||
| auto overwrite_or_ignore = deserializer.ReadProperty<bool>(203, "overwrite_or_ignore"); | |||
There was a problem hiding this comment.
Don't we need some way to map true to CopyOverwriteMode::COPY_OVERWRITE_OR_IGNORE at deserialization for backwards compatibility?
Or is that not as important for LogicalCopyToFile?
There was a problem hiding this comment.
Booleans are serialized as single bytes - where 0 is false and 1 is true. The new enum is also serialized as a single byte (CopyOverwriteMode : uint8_t), where 0 is COPY_ERROR_ON_CONFLICT and 1 is COPY_OVERWRITE . So this should work correctly already.
Mytherin
added
the
Needs Documentation
Closed
2 tasks
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Jun 5, 2024
Merge pull request duckdb/duckdb#12240 from Mytherin/overwriteorignore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12225
This PR reverts
OVERWRITE_OR_IGNOREto the previous behavior where files are overwritten if they exist, or ignored (left alone) if they do not. The new behavior introduced in #11787 is instead moved to a new flag (OVERWRITE). The new flag is more explicit in what it does, and is also explicitly disabled for remote file systems (e.g. S3) where we don't support removing files yet.