[Block Size] String block limit and a few other places #12671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nightly passed before merging the latest |
|
Latest nightly run: https://github.com/taniabogatsch/duckdb/actions/runs/9642358450 |
|
Thanks! |
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Jun 24, 2024
Merge pull request duckdb/duckdb#12671 from taniabogatsch/bs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the PR title says, this PR removes the
STRING_BLOCK_LIMITconstant by adapting it to the block size.@samansmink, I ran all benchmarks in
benchmark/micro/compression/fsst*, and did not notice a regression. So I assume reusing the samevectordoes not impact performance.Note that there also a few other places in this PR where I removed
*_BLOCK_SIZE