Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serialization: add CustomData and better support for integrating with extensions #12681

Merged
merged 5 commits into from
Jun 26, 2024

Conversation

jeewonhh
Copy link
Contributor

Adding CustomData to SerializationData to support the serialization of customized data for extensions.

@Maxxen
Copy link
Member

Maxxen commented Jun 24, 2024

Im curious, why do you want this?
Allowing extensions to push custom serialization is a little scary as you could end up breaking the storage format very easily if the extension makes backwards incompatible changes to what it serializes. Additionally we will probably remove support for custom serializer implementations in general and move e.g. the json serializer into core.

@Mytherin Mytherin merged commit a5e12fe into duckdb:main Jun 26, 2024
38 checks passed
@Mytherin
Copy link
Collaborator

Thanks!

github-actions bot pushed a commit to duckdb/duckdb-r that referenced this pull request Jun 26, 2024
Merge pull request duckdb/duckdb#12681 from jeewonhh/jeewon/serializer-customdata
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants