Implementing Filter Clause for aggregates #1309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mytherin
reviewed
Jan 21, 2021
src/execution/operator/aggregate/physical_perfecthash_aggregate.cpp
Outdated
Show resolved
Hide resolved
src/include/duckdb/execution/operator/aggregate/physical_hash_aggregate.hpp
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,273 @@ | |||
| # name: test/sql/filter/test_filter_clause.test | |||
| # description: Test aggregation with filter clause | |||
There was a problem hiding this comment.
I would like some more test cases:
- Query with many different filter clauses (e.g. 5 aggregates, 5 different filters)
- Filter with some more complex aggregates:
COVAR_POP(multiple input columns),STRING_AGG(strings) andARRAY_AGG(lists) - DISTINCT aggregates
Also; looking at these tests I would not be surprised if all of them use the perfect hash aggregate. You can force the regular hash aggregate to be used by using very spaced out groups (e.g. [0, 10000000, 20000000, ....]).
|
Thanks, this looks great now! |
|
So this |
hannes
reviewed
May 6, 2021
| auto &bound_ref_expr = (BoundReferenceExpression &)*aggr.filter; | ||
| auto it = ht.find(aggr.filter.get()); | ||
| if (it == ht.end()) { | ||
| aggregate_input_chunk.data[aggregate_input_idx].Reference(input.data[bound_ref_expr.index]); |
|
Will fix just thought I'd note for future reference |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR gives a (potentially over-complicated binding process, please check that) implementation of the filter clause for aggregates #896