Implementing Unsigned Types #1325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Very nice, out of curiosity, how much does this increases the binary size? |
|
14mb with unsigned types, 13mb on master |
|
Did you double-check the parquet statistics for the uints are correctly converted? |
|
Yes! The only issue I found with the parquet files was the uint32 being converted to int64. |
Mytherin
reviewed
Jan 26, 2021
|
@Mytherin you got me on the storage. hehe |
|
Thanks, looks great now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task #1023
Since the unsigned types are built-in I think the most relevant changes are in the cast operators. Let me know if I forgot any interface or if I should add any other relevant tests.