#1791: Nested hash table entries #1863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 25 commits
June 7, 2021 10:31
Refactor the RowOperations::Gather to not require a RowLayout as the only thing it uses is the col_offset and most callers have easy access to that.
Test grouping by nested types.
Implement joining on nested types. This required some questionable template specialisation for Values.
Fix Vector passing to actually work.
Tidy name.
Replace Value code for STRUCT comparisons with recursive templates.
Delegate nested row matching to the column matching logic. Fix incorrect short-circuiting for IS (NOT) DISTINCT tests (the values may not be valid if they are NULL).
Implement PositionComparator variants.
Convert STRUCT hashing from Values to recursive scalar evaluation.
Convert LIST hashing from Values to recursive scalar evaluation.
Fix selection typo.
Factor out common STRUCT code for reuse with LIST. Compile LIST variant, but don't deploy.
Switch over to recursive vectorised LIST comparisons. Fix bug in Is(Not)Distinct code where matches were not being selected.
Back out unnecessary Value changes.
…ckdb into hawkfish-nested-keys
Remove pointless STRUCT child munging.
Implement nested Is (Not) Distinct comparators.
Add tests to verify grouping by nested types.
Refactor to avoid name collisions.
Fix confusing cancelling coding errors.
Mytherin
reviewed
Jun 14, 2021
added 4 commits
June 14, 2021 09:55
…o hawkfish-nested-keys
…into hawkfish-nested-compare
Vectorised Combine for LIST.
added 2 commits
June 14, 2021 12:16
Implement (in)equality boolean comparison functions for nested types
Expose hash table selection logic as comparison/distinction predicates.
Replace duplicate code with calls to the original.
|
Thanks for the fixes! Looks great. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for nested types as aggregate and join keys.