Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Perfect Hash Join #1959
Perfect Hash Join #1959
Changes from 98 commits
33d309f
656c7f7
9925b05
5b833c5
2634e69
b31e717
a545967
244a35a
20fa952
46ea7ea
d373392
1d61fc0
f438825
d568c5d
e6df3b7
4acb1d2
48a3e0c
1dd4063
e2a8841
49b3000
07b5f4b
6c3ddf1
852d0c1
724e320
eca0065
a20b1cc
c3730cf
1dc5e93
cc5ed9f
4508830
5a4d82d
688d721
99d21c6
158138c
9004438
ad31f83
05c3c71
b565ef6
93afa21
5f29c25
26e7d44
7a6ba61
1b418ec
f8f66bf
8bad438
9347a2c
a1de9ad
89b3fc7
751eb08
62d8b34
a9e9c67
6769619
7917f6c
2cef8da
582f0bb
4547b4c
88afbf1
48d9193
2cbc951
ce3019f
ef41cca
be6fec1
20e4512
00c4b47
8716314
96168a3
d125648
3472e16
e128e7c
2694620
a61f5c1
fb15fed
4b038df
a3681e9
2548c83
d4f4813
6fcb961
ce581e2
571d8d0
241ba8a
b49c400
3d9dc41
67fa02f
89d3e74
c4eb83d
c575e25
65823f9
a0e10ce
b3045b1
7cd22f3
8bcf1ce
5505012
e4b7950
cfd1a75
dfdbefd
33b9755
166d699
ef37a8c
be3d70c
0e8773c
6464e9f
1e9c77f
f2f9bb6
0ee7b63
8f767c4
f7f9f23
9e2b49d
a754dee
61de84c
7d42096
7a0e4e4
8bfcc33
5d53052
1da8d54
93f6502
5e0a200
ee8140c
2af736c
a0f9a93
a77f703
a6ba64b
726173a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line is uncovered. Could you add a test that covers this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For this line to be hit we need null values in the hash table.
However null comparisons are not done in this join, they are skipped in a phase prior to that.
I don't think we should remove this code, because at some point we might implement it anyway, but it is "unreachable" through testing right now. What you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps turn this into an internal exception for now if it is never supposed to be triggered currently, with the line of code commented out? If we need it in the future we can remove the exception again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost none of these types are covered. Could you add tests for all these types?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You did some type loop for the tests right? Can you point me out to one of these files?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See e.g. here