New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regression Test: TPC-DS/H20AI and other adjustments #2263
Conversation
…ion script to only re-run queries if they were not on the same time
So, I've changed how things work a bit. I'm still comparing against the latest master python wheel, but now the PR is built under a different library name. This allows me to only perform re-runs on queries that did not present the same result. This should speed up the regression tests and hopefully, diminish the chances of false (positive or negatives) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Looks good. Some minor comments:
Looks good, thanks! |
I've added TPC-DS to the regression tests (Except queries 64,72,85)
I've increased the number of repetitions from 3 to 5 (Should take 1 - 1:30 to run), in an attempt of diminishing false negatives.
The output of the run will look something like this, which seems to me is a bit much info, so I can also adjust it to only print queries that were slower, or faster and slower, or maybe also cluster them into groups? In the end, I guess if the test breaks a simple ctrl F is enough to find the slower queries, but I'm happy to hear suggestions.: