Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #2552: SUBSTR BIGINT #2642

Merged
merged 1 commit into from
Nov 20, 2021
Merged

Issue #2552: SUBSTR BIGINT #2642

merged 1 commit into from
Nov 20, 2021

Conversation

hawkfish
Copy link
Contributor

Change the argument type of SUBSTR to BIGINT.
Fix default length to avoid overflow.

Issue duckdb#2552: SUBSTR BIGINT
d4bc02e 
Change the argument type of SUBSTR to BIGINT.
Fix default length to avoid overflow.
@hawkfish
Copy link
Contributor Author

Actually #2553 - I fat fingered my commit message...

@Mytherin Mytherin linked an issue Nov 20, 2021 that may be closed by this pull request
the substr only accept integer, it cannot use instr as argument directly #2553
Closed
@Mytherin Mytherin merged commit 7c70a1d into duckdb:master Nov 20, 2021
@Mytherin
Copy link
Collaborator

Thanks!

@hawkfish hawkfish deleted the hawkfish-substr-bigint branch November 21, 2021 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

the substr only accept integer, it cannot use instr as argument directly
2 participants
@hawkfish @Mytherin