Fix various Windows unicode issues #2658

Mytherin · 2021-11-23T14:00:41Z

This PR fixes various unicode issues on Windows, specifically:

Fixes nmake cmake fail under vs 2017 x64 #2654 by specifying /utf-8 when compiling on MSVC
Fixes CSV with Chinese name cannot copy into DuckDB in Windows #2628 by adding code to converting from UTF8 to Windows' unique unicode representation and using the Unicode-specific API's in the file system (CreateFileW and friends)
Fixes how to show explain query results in ascii mode? #2507 by printing EXPLAIN and profile results to the terminal using Windows' other unique unicode representation (because there are multiple different ones! wow!)

…he code

…indowsunicodeyay

…ABLE_PRINT is defined

Mytherin added 19 commits November 23, 2021 09:15

/utf-8 flag

843faf6

Escape unicode sequences instead of defining the UTF-8 sequences in t…

fc0d276

…he code

utf8_printf for explain

6c2662c

Unicode filename test

6fe3f10

Add WindowsUtil and attempt to use it

fee8dca

Various windows unicode fixes in file system

088d3ea

Windows fixes

5c17025

Merge branch 'windowsunicodeyay' of github.com:Mytherin/duckdb into w…

c59f4b8

…indowsunicodeyay

Format fix

3e91e86

Printer rendering for windows terminal

c50641e

CSV for unicode blob search

5623b99

Windows fixes

68a3a29

Clean up helper functions

6ecf66b

Cancel should request a cancel of all workflows, not just main

ed1e852

Avoid calling DeleteDirectoryW on directories that do not exist

4753e18

Use GetFileType to determine if a node is a terminal or not

8bc6d81

Revert left-over of change

686d9f4

Regenerate flex, and add missing return to printer in case DUCKDB_DIS…

912caf4

…ABLE_PRINT is defined

Merge branch 'master' into windowsunicodeyay

00b4d84

Mytherin merged commit 1f9b8f4 into duckdb:master Nov 24, 2021

Mytherin deleted the windowsunicodeyay branch December 3, 2021 14:24

Provide feedback