Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #2614: Wide windows #2660

Merged
merged 8 commits into from
Nov 24, 2021
Merged

Conversation

hawkfish
Copy link
Contributor

Make the bias argument explicit so the caller can optimise data usage.
Switch to using and appending chunks.
Add wide frame test and fix reference/copy transition.

Copy link
Collaborator

@Mytherin Mytherin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Looks good, one minor comment w.r.t. code coverage:

test/sql/window/test_window_wide_frame.test_slow Outdated Show resolved Hide resolved
src/execution/window_segment_tree.cpp Show resolved Hide resolved
src/execution/window_segment_tree.cpp Show resolved Hide resolved
Richard Wesley added 2 commits November 24, 2021 06:17
@Mytherin Mytherin merged commit f865005 into duckdb:master Nov 24, 2021
@Mytherin
Copy link
Collaborator

Thanks!

@hawkfish hawkfish deleted the hawkfish-wide-window branch December 1, 2021 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants