Fix #2471: correctly handle offset passed by ::UpdateSegment, and handle it earlier to clean up code #2723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd handle it earlier to clean upc ode
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a crash that occurred in #2471. This crash would occur when running an
UPDATEsegment with aFROMclause that resulted in the same source vector updating multiple different target vectors. The offset was then used to specify which segment of the vector should be used to perform the update, but this was not properly used throughout theUpdateSegment::Update. We resolve this by using the offset earlier to slice the vector. This simplifies the implementation and resolves the bug.