Issue #561: ICU Date addition #2730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 13 commits
December 1, 2021 12:49
Clean up the templates to have better names and type inference.
Implement TIMESTAMPTZ + INTERVAL using ICU.
Backout Window extension break.
…to hawkfish-icu-datediff
Implement TIMESTAMPTZ - INTERVAL Test commutative, subtraction and pre-epoch addition.
… into hawkfish-time-zone
…ckdb into hawkfish-icu-dateadd
|
I don't understand why the coverage went down - none of the files in the PR are listed! |
The project coverage is a bit finnicky because there are race conditions in the coverage that cause minor fluctuations (i.e. sometimes certain lines of code will not be executed because of threading). I have tried before to prevent it from pushing a failure in case of a minor decrease for that reason, but could not manage to get codecov to obey as of yet. |
Mytherin
reviewed
Dec 6, 2021
added 3 commits
December 6, 2021 09:18
Add limits tests.
Fix Windows linkage.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement adding and subtracting
INTERVALto and fromTIMESTAMPTZ