Enum Functions #2793
Enum Functions #2793
Conversation
src/common/types.cpp
Outdated
| idx_t EnumType::GetValuePosition(const Value &val) { | ||
| switch (val.type().InternalType()) { | ||
| case PhysicalType::UINT8: | ||
| return val.value_.utinyint; |
There was a problem hiding this comment.
val.GetValue<uint32_t>() should cover all these three cases so the switch is no longer required
There was a problem hiding this comment.
it doesn't but i've moved it there.
| } | ||
|
|
||
| void EnumFirst::RegisterFunction(BuiltinFunctions &set) { | ||
| set.AddFunction(ScalarFunction("enum_first", {LogicalType::ANY}, LogicalType::VARCHAR, EnumFirstFunction, false, |
There was a problem hiding this comment.
I know you have a binder, but maybe ANY should be ENUM? I'm not sure how the candidate functions will be displayed in the situation where there are too many or too few arguments.
There was a problem hiding this comment.
The problem here is that the creation and equality of enum types are associated with the enum categories. I guess we could to these matches on LogicalTypeIDs, but I think @Mytherin prefers these binding setups
There was a problem hiding this comment.
Binding on an empty type is how the list functions do this, e.g. unnest binds on {LogicalTypeId::LIST}. Perhaps this should indeed bind on LogicalTypeId::ENUM instead of ANY.
|
Thanks! |
Issue: #2741 and #2740