Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor SQLLogicTest #2806

Merged
merged 10 commits into from
Dec 18, 2021
Merged

Refactor SQLLogicTest #2806

merged 10 commits into from
Dec 18, 2021

Conversation

Mytherin
Copy link
Collaborator

This PR refactors and cleans up the SQLLogicTest framework by splitting it up into multiple files and making the code actually consistent with the rest of the project. In total the changes are as follows:

  • The test runner is partitioned into different components (SQLLogicTestRunner, Command, TestParser, TestResultHelper) that are placed in separate files.
  • Rewrite the test parser to be proper C++
  • Rename functions and variables to be consistent with the remainder of the project
  • Use classes (yay) so we can avoid having function calls with many parameters

@Mytherin Mytherin merged commit a679c6b into duckdb:master Dec 18, 2021
@Mytherin Mytherin deleted the cppsqllogictest branch June 21, 2022 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant