Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #2834: ICU BindAdapterData::Equals #2835

Merged
merged 1 commit into from
Dec 23, 2021
Merged

Issue #2834: ICU BindAdapterData::Equals #2835

merged 1 commit into from
Dec 23, 2021

Conversation

hawkfish
Copy link
Contributor

Add Equals method to prevent aliasing of ICU part functions.

Issue duckdb#2834: ICU BindAdapterData::Equals
c061f71 
Add Equals method to prevent aliasing of ICU part functions.
@Mytherin
Copy link
Collaborator

Thanks! The base equality for FunctionData really should default to false (or even just require being overridden).

@Mytherin Mytherin merged commit 7473f3e into duckdb:master Dec 23, 2021
@hawkfish hawkfish deleted the hawkfish-2834 branch December 23, 2021 14:25
@hawkfish
Copy link
Contributor Author

Yeah I thought about that but it seemed like it could be a large can of worms. Maybe a separate issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hawkfish @Mytherin