Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix potential use after move detected by linter, and add DISABLE_DUCKDB_REMOTE_INSTALL define #2837

Merged
merged 1 commit into from
Dec 23, 2021
Merged

Fix potential use after move detected by linter, and add DISABLE_DUCKDB_REMOTE_INSTALL define #2837

merged 1 commit into from
Dec 23, 2021

Conversation

Mytherin
Copy link
Collaborator

This adds support for the DISABLE_DUCKDB_REMOTE_INSTALL define, which disables loading of httplib, which should remove any usage of std::regex.

CC @mbasmanova @majetideepak

@Mytherin Mytherin mentioned this pull request Dec 23, 2021
Closed
mbasmanova
mbasmanova approved these changes Dec 23, 2021
View reviewed changes
Copy link

@mbasmanova mbasmanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Mark.

@Mytherin Mytherin merged commit f338ea4 into duckdb:master Dec 23, 2021
@Mytherin Mytherin deleted the fbtidyfixes branch January 17, 2022 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbasmanova mbasmanova mbasmanova approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Mytherin @mbasmanova