Issue #2827: Postgres datepart compatibility #2852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 13 commits
December 20, 2021 20:49
Replace the poorly named and incompatible `offset` part name with the Postgres `timezone...` part names.
Change the millennium and century extractors to match Postgres.
Fix and test timezone_minute calculation.
Share millenium and other computations with the struct generation.
Correct problem where `DATE_PART(['epoch',...], ts)` was dropping the seconds from the time component. Add tests to all types to make sure that the struct values match the scalar values.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
offsetpart name with the Postgrestimezone...part names.millenniumandcenturyextractors to match Postgrestimezone_minutecalculationSTRUCTgenerationDATE_PART(['epoch',...], ts)was dropping the seconds from the time component.