Issue #2782: Non-Gregorian Calendars #2865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 3, 2022 13:46
Allow the user to change the current calendar used by ICU via ```sql Set Calendar='<name>'; ``` Test it using the Japanese imperial eras.
|
I should know better than to second guess ICU's time nerds... Think I should fix this before it ends up in our permanent code base. |
Fix arrogant (and incorrect) comment on the Meiji era.
|
In case anyone ever asks, I have a tsv that maps the era numbers to the Japanese (Kanji) names and the English transcriptions, along with the date boundaries. |
|
The sanitiser failure looks unrelated? |
|
Indeed it is. Thanks! Looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the user to change the current calendar used by ICU via
Test it using the Japanese imperial eras.