Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src/include/duckdb/common/assert.hpp: Added winapi #2939

Merged
merged 1 commit into from
Jan 18, 2022

Conversation

emmenlau
Copy link
Contributor

When building duckdb with the LLVM ClangCl compiler frontend 13.0.0 in front of Visual Studio 2019 v16.11 and using ninja, I get an error about an undefined symbol:

lld-link: error: undefined symbol: void __cdecl duckdb::DuckDBAssertInternal(bool, char const *, char const *, int)
>>> referenced by C:\BDA\bld\XTJyb_7r\0\duckdb\src\include\duckdb\common\types\string_type.hpp:32
>>>               test\extension\CMakeFiles\loadable_extension_demo.dir\loadable_extension_demo.cpp.obj:(public: __cdecl duckdb::string_t::string_t(char const *, unsigned int))
>>> referenced by C:\BDA\bld\XTJyb_7r\0\duckdb\src\include\duckdb\common\types\vector.hpp:217
>>>               test\extension\CMakeFiles\loadable_extension_demo.dir\loadable_extension_demo.cpp.obj:(public: static bool __cdecl duckdb::ConstantVector::IsNull(class duckdb::Vector const &))
>>> referenced by C:\BDA\bld\XTJyb_7r\0\duckdb\src\include\duckdb\common\types\vector.hpp:222
>>>               test\extension\CMakeFiles\loadable_extension_demo.dir\loadable_extension_demo.cpp.obj:(public: static struct duckdb::ValidityMask & __cdecl duckdb::ConstantVector::Validity(class duckdb::Vector &))
>>> referenced 8 more times

To resolve this error, I have to add the DLL export for DuckDBAssertInternal.

@Mytherin
Copy link
Collaborator

Thanks for the PR! Looks good. Failures are unrelated to the PR and related to some other CI hickups we had recently.

@Mytherin Mytherin merged commit 624fa8a into duckdb:master Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants