fix: use selection vector to ensure ids are ordered #2956
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
static idx_t SortSelectionVector(SelectionVector &sel, idx_t count, row_t *ids)
SortSelectionVector does not actually sort ids, but ensures that ids are ordered through SelectionVector
The algorithm in CheckForConflicts needs to traverse the ids in order, which requires a SelectionVector to guarantee.