ODBC: SQLGetTypeInfo, SQLTables, and SQLColumns #2973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mytherin
reviewed
Jan 24, 2022
tools/odbc/api_info.cpp
Outdated
| bool first = true; | ||
| for (auto info_type : vec_types) { | ||
| query += "("; | ||
| if (first) { |
There was a problem hiding this comment.
Is this first necessary or can we always output the casts?
tools/odbc/include/odbc_utils.hpp
Outdated
| #include <string> | ||
| #include <vector> | ||
|
|
||
| using std::string; |
There was a problem hiding this comment.
Please avoid using in headers
tools/odbc/odbc_utils.cpp
Outdated
| string OdbcUtils::GetQueryDuckdbColumns(const string &catalog_filter, const string &schema_filter, | ||
| const string &table_filter, const string &column_filter) { | ||
| string sql_duckdb_columns = | ||
| "SELECT " |
There was a problem hiding this comment.
SQL statements can be made a lot more readable by using multi-line string literals, e.g.:
string sql_duckdb_columns = R"(
SELECT NULL "TABLE_CAT",
schema_name, ...
)";
|
Thanks for the updates! Looks great. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey all,
This PR implements the functions: SQLGetTypeInfo, SQLTables, and SQLColumns, according with the ODBC conformance core level.