Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lookup parent frames for replacement scans #3000

Merged
merged 2 commits into from
Feb 1, 2022
Merged

Conversation

pdet
Copy link
Contributor

@pdet pdet commented Jan 27, 2022

Fix: #2966

@DAVIDWALES if possible can you check if this fixes ur problem?

@ghost
Copy link

ghost commented Jan 27, 2022

@pdet Is there a build artifact I can try? Or do I need to build from source?

@Mytherin
Copy link
Collaborator

Is there any way to add a test for this, e.g. could we run ipython in the CI somehow?

@Mytherin
Copy link
Collaborator

Task: #2966

Also minor note, github doesn't seem to recognize "Task:" as a closing keyword. If you could use "fixes" (or another term from that list) the PR will be automatically linked to the issue.

@pdet
Copy link
Contributor Author

pdet commented Jan 28, 2022

Is there any way to add a test for this, e.g. could we run ipython in the CI somehow?

We add Ipython as a dependency, I'm not entirely sure how to capture the return value of the display function in order to assert that the query succeded

@Mytherin
Copy link
Collaborator

Traceback (most recent call last):
16
  File "scripts/regression_test.py", line 179, in <module>
17
    regression_test(0.15,benchmark)
18
  File "scripts/regression_test.py", line 167, in regression_test
19
    regression_status = run_h2oai(repetitions, threshold)
20
  File "scripts/regression_test.py", line 149, in run_h2oai
21
    load_h2oai(duckdb_conn,duckdb_current_conn)
22
  File "scripts/regression_test.py", line 108, in load_h2oai
23
    duckdb_current_conn.execute("CREATE TABLE x_group as SELECT * FROM 'G1_1e7_1e2_5_0.csv.gz'")
24
RuntimeError: AttributeError: 'NoneType' object has no attribute 'f_locals'
25

Could you look at the test failure? This seems related to the changes made in this PR.

@Mytherin Mytherin merged commit 9552f65 into duckdb:master Feb 1, 2022
@Mytherin
Copy link
Collaborator

Mytherin commented Feb 1, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants