Fix #2986: correctly copy old data over when calling repalloc in parser #3011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hawkfish
approved these changes
Jan 31, 2022
| @@ -55,12 +55,17 @@ static void allocate_new(parser_state *state, size_t n) { | |||
|
|
|||
| void *palloc(size_t n) { | |||
| // we need to align our pointers for the sanitizer | |||
| auto aligned_n = ((n + 7) / 8) * 8; | |||
| auto allocate_n = n + sizeof(size_t); | |||
| auto aligned_n = ((allocate_n + 7) / 8) * 8; | |||
There was a problem hiding this comment.
Don't we have a utility function for this somewhere? Align or something?
There was a problem hiding this comment.
Yes, but since this is in the libpg_query library in the third_party folder we prefer not to link it back to the main DuckDB sources.
There was a problem hiding this comment.
That's what I figured, but thought I should ask.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2986