Update Java DuckDBAppender to allow appending null values - fixes issue 3035 #3039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates Java DuckDBAppender to allow appending null values. The version of the append method that takes a java.lang.String now properly handles being passed null by invoking the corresponding version of the C++ Appender class to append a null value, regardless of column type. Includes additional unit tests to verify that null values can now be appended in integer and varchar columns. Closes #3035.
Looks like it fixed some indentation issues in duckdb_java.cpp.
rkennedy-mode
changed the title
|
Thanks for the PR! Looks good to me, but perhaps someone more versed in Java wants to have a look? @hannesmuehleisen or @hawkfish ? |
|
Lgtm |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates Java DuckDBAppender to allow appending null values. The version of the append method that takes a java.lang.String now properly handles being passed null by invoking the corresponding version of the C++ Appender class to append a null value, regardless of column type.
Includes additional unit tests to verify that null values can now be appended in integer and varchar columns.
Closes #3035.