[C-API] Data chunk invalid left-shift #4660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As suggested in the issue, can you please double check whether there are other problematic instances of this shift in the codebase? |
Yes will do 👍 |
|
Thanks can you also double check what happened to your ICU? There's a giant diff there. |
|
Yea it's caused by format-master, I'll redo the changes without formatting I guess I somehow broke Julia, it cant find |
|
Thanks, but I would probably say let's not do this fix in the third_party stuff. @Mytherin do you agree? |
|
Agreed let’s skip the ICU fixes, it’s likely the code is never even run |
…ecked to be positive)
Tishj
commented
Sep 11, 2022
Tishj
commented
Sep 11, 2022
begelundmuller
added a commit
to begelundmuller/go-duckdb
that referenced
this pull request
Sep 12, 2022
marcboeker
pushed a commit
to marcboeker/go-duckdb
that referenced
this pull request
Sep 27, 2022
* Use DuckDB amalgamation instead of shared libraries * Patch amalgamation for Windows pending release of duckdb/duckdb@fe328d3 * Add build flags for Windows compilation * Bundle static libraries, and make source and shared libraries optional * Run go test only in root * Prepare deps workflow for merge into main * Fix include path for compile from source * Fix bug for compiling from source * Trigger deps build when DUCKDB_VERSION is updated * Test automated deps PR by downgrading to v0.4.0 * Test automated deps PR by downgrading to v0.4.0 * CI to build static libraries when upgrading DuckDB version * Fix bug in deps.yaml * Change use_source to from_soure * Fix bug in static library commit * Copy over fix from duckdb/duckdb#4660 * Test with touch * Test on all paths * Bugfix: bad path name in CI * Re-build static libraries * Now run actual build * Re-build static libraries * Update documentation * Clean up deps build * Tidy up imports * bugfix: empty results would return a row * Clean up gcc flags * Run lib builds (tmp) * Trigger build on main * Re-build static libraries * Revert to build static libs only on PR * Build static libs on non-master changes to duckdb files Co-authored-by: begelundmuller <begelundmuller@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #4499
It's a simple oversight, the type of
1defaults toint32_t, causing a shift with any value larger than/equal to 32 produces an incorrect result.