-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing Extension naming CI Checker #4717
Conversation
# root_dir needs a trailing slash (i.e. /root/dir/) | ||
extension_path = {} | ||
for filename in glob.iglob('/tmp/' + '**/*.duckdb_extension', recursive=True): | ||
extension_path[filename.split("/")[-1].split('.')[0]] = filename |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use os.path.splitext/basename here instead
@@ -39,12 +46,16 @@ | |||
if args.validate: | |||
cur_function_map = {} | |||
file = open(os.path.join("..","src","include","extension_functions.hpp"),'r') | |||
pattern = re.compile("{\"(.*?)\", \"(.*?)\"},") | |||
pattern = re.compile("(.*?){\"(.*?)\", \"(.*?)\"},") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not just use findall instead of iterating over every line in the file?
@Mytherin if you don't have any comments this is good to go. |
Thanks! |
Fixes: #4671