Julia API: Add load! to add a DataFrame as a table #4743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as proposed in [duckdb#4641](duckdb#4641), this PR adds a function `load!(con, df, table)` to add a DataFrame as a DuckDB table, mimicking the SQLite.jl API. Compared to the existing `appendDataFrame`, I changed the `INSERT INTO` into the `CREATE TABLE AS` also proposed in the issue to match the semantics of `load!`. Also, for `load!` I put the connection as the first argument, as the `!` convention usually indicates the first argument being mutated. I wasn't quite sure where to put the function, so I put it where `appendDataFrame` was for now. Feel free to move things around!
Mytherin
reviewed
Sep 18, 2022
tools/juliapkg/src/old_interface.jl
Outdated
| function load!(con::Connection, input_df::DataFrame, table::AbstractString, schema::String = "main") | ||
| register_data_frame(con, input_df, "__append_df") | ||
| DBInterface.execute(con, "CREATE TABLE \"$schema\".\"$table\" AS SELECT * FROM __append_df") | ||
| return unregister_data_frame(con, "__append_df") |
There was a problem hiding this comment.
Is this supposed to be the return value?
There was a problem hiding this comment.
That's what append_data_frame had done before. As unregister_data_frame just returns nothing, I made that more explicit now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as proposed in #4641, this PR adds a function
load!(con, df, table)to add a DataFrame as a DuckDB table, mimicking the SQLite.jl API.Compared to the existing
appendDataFrame, I changed theINSERT INTOinto theCREATE TABLE ASalso proposed in the issue to match the semantics ofload!. Also, forload!I put the connection as the first argument, as the!convention usually indicates the first argument being mutated.I wasn't quite sure where to put the function, so I put it where
appendDataFramewas for now. Feel free to move things around!