aarch64 extensions #4745
Merged
aarch64 extensions #4745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mause
reviewed
Sep 19, 2022
| - uses: ./.github/actions/ubuntu_16_setup | ||
| with: | ||
| openssl: 1 | ||
| aarch64_cross_compile: 1 |
There was a problem hiding this comment.
Is there a reason we use numbers instead of booleans everywhere for these flags?
There was a problem hiding this comment.
Good point, they should definitely be booleans, will change this in a next PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr adds a build step to CI for cross compiling the extensions for linux aarch64. Out of tree extensions are not yet included, will look at those tomorrow.