Convert values whose data types do not have explicit support in NodeJS into strings #5130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwills
changed the title
|
Thanks! LGTM |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5125
I thought it would be worthwhile to follow what the
node-postgresproject does and convert values for DuckDB data types that do not have corresponding support in Javascript into strings:https://node-postgres.com/features/types
This PR changes the
defaultbehavior for type conversion from throwing an exception (that crashes the interpreter) to one where we return a string usingValue.ToStringand tests that this fixes the issue with returningTIMEtypes from queries to NodeJS.