-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding lazy relation -> data.frame conversion for R client #5181
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
…ry duckdb vector we transform
@krlmlr do we need to remove the examples for the un-exported methods? R CMD check does not seem to like them. |
I think so, yes.
|
relaltrepdf-2 # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
I'm also wondering why those things have to be private in the first place. Maybe its better to mark them experimental. |
We agreed that keeping the functions private will make it easier for us later to use the new relational package. What is the advantage of keeping them exported? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have a strong opinion regarding reexport, I see there is now a message that explicitly alerts users. Would you like a beautiful orange badge, like in https://dplyr.tidyverse.org/reference/rows.html?
Since this pulls in the lifecycle package I am adding |
We add functionality to convert a R DuckDB relation object to a data.frame without actually computing the query result using lazy ALTREP vectors. This works great except for list/struct/blob columns. There is hope R will add list ALTREP support soon-ish, which should remove the limitation.