Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature request link #5324

Merged
merged 6 commits into from
Nov 29, 2022
Merged

Add feature request link #5324

merged 6 commits into from
Nov 29, 2022

Conversation

Mause
Copy link
Member

@Mause Mause commented Nov 14, 2022

This is very much a first attempt and probably needs revising

This also tweaks the config to forbid issues not based on one of the two templates, which will hopefully improve the quality of submitted issues

@Mause
Copy link
Member Author

Mause commented Nov 14, 2022

If you'd like to preview what this looks like, you can have a look at my fork: https://github.com/Mause/duckdb/issues/new/choose

@hannes
Copy link
Member

hannes commented Nov 14, 2022

I am moving those to discussions. Is it possible to have a template here you can't actually open an issue but that just says "open a discussion thing"?

@Mause
Copy link
Member Author

Mause commented Nov 14, 2022

I am moving those to discussions. Is it possible to have a template here you can't actually open an issue but that just says "open a discussion thing"?

image
Like this?

@Mytherin
Copy link
Collaborator

Opening feature requests as issues is fine as long as we want the issue to be implemented - i.e. you have discussed this with us and we have agreed it is a good idea. That should be clear (and perhaps enforced through a checkbox or similar). We want to avoid people opening issues with "I want DuckDB to have X" - those should be discussions.

@Mause
Copy link
Member Author

Mause commented Nov 14, 2022

Could try to enforce it by asking for a link to the discussion as a required field?

@Mause Mause changed the title Add feature request template Add feature request link Nov 15, 2022
@Mause
Copy link
Member Author

Mause commented Nov 15, 2022

Hopefully we'll get proper discussion templates soon: community/community#2838 (reply in thread)

@Mytherin
Copy link
Collaborator

Mytherin commented Nov 17, 2022

Looks fine to me - although we might still want to have feature requests with the caveat that they can only be opened either (1) by team members/foundation members/customers, or (2) after discussion with us. I think disabling the blank issues is a great idea though

@Mytherin Mytherin merged commit 8948cea into duckdb:master Nov 29, 2022
@Mytherin
Copy link
Collaborator

Thanks again for making this - we should give these templates a go as people are still confused.

@Mause Mause deleted the patch-1 branch December 14, 2022 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants