Add in the pg_database, pg_proc, and pg_settings views to pg_catalog #5526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 28, 2022 14:22
…atalog for my DuckDB postgres proxy layer with minimal impls and tests
|
Thanks for the PR! Looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm putting just enough into the implementation here to work for my use case, but obviously happy to add any other bits, rename things, etc. to make this useful for folks.
References:
pg_settings: https://www.postgresql.org/docs/9.1/view-pg-settings.htmlpg_database: https://www.postgresql.org/docs/9.1/catalog-pg-database.htmlpg_proc: https://www.postgresql.org/docs/9.1/catalog-pg-proc.htmlAlso noting that I would like/need to tackle a richer impl of
pg_descriptionfor some of my use cases in the near future!