Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding dummy user/username/password settings #5530

Merged
merged 4 commits into from
Nov 29, 2022
Merged

Adding dummy user/username/password settings #5530

merged 4 commits into from
Nov 29, 2022

Conversation

hannes
Copy link
Member

@hannes hannes commented Nov 29, 2022

No description provided.

@hannes hannes linked an issue Nov 29, 2022 that may be closed by this pull request
JDBC Squirrel connection asking for password in .6 Was working in .5.9 #5498
Closed
2 tasks
Mytherin
Mytherin reviewed Nov 29, 2022
View reviewed changes
Copy link
Collaborator

@Mytherin Mytherin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Looks good. One comment:

src/main/config.cpp Show resolved Hide resolved
@hannes
Copy link
Member Author

hannes commented Nov 29, 2022

Failures only concern CodeCov so far

@hannes hannes merged commit 1e443c4 into duckdb:master Nov 29, 2022
@hannes hannes deleted the jdbcuserpwignorelma branch March 1, 2023 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mytherin Mytherin Mytherin left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JDBC Squirrel connection asking for password in .6 Was working in .5.9
2 participants
@hannes @Mytherin