Deprecate 'sprintf' usage using MacOSX SDK 13 #5545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pedroerp - since you had experience to build duckdb code, would you help review this PR? |
hannes
reviewed
Nov 30, 2022
extension/tpch/dbgen/build.cpp
Outdated
| sprintf(target + 7, "%03d", (int)exchg); | ||
| sprintf(target + 11, "%04d", (int)number); | ||
| snprintf(target, PHONE_LEN, "%02d", (int)(10 + (ind % NATIONS_MAX))); | ||
| snprintf(target + 3, PHONE_LEN, "%03d", (int)acode); |
There was a problem hiding this comment.
if we snprintf to ptr + 3, isn't PHONE_LEN too much n by 3?
There was a problem hiding this comment.
Thanks for pointing out!
I've amended a fix to set the correct buffer size with a few tests: https://onlinegdb.com/XL_2XQdz1
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(This change will be a dependency to fix a Velox build failure, see facebookincubator/velox#3370)
Using MacOS 13.0 sdk, you may notice the following build error:
The alternative safer function is
snprintf.Reference: https://stackoverflow.com/a/2169039