Maintain BlockHandle of meta blocks by BlockManager #5699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mytherin
reviewed
Dec 15, 2022
src/storage/buffer_manager.cpp
Outdated
| @@ -268,6 +268,12 @@ shared_ptr<BlockHandle> BlockManager::RegisterBlock(block_id_t block_id) { | |||
| return result; | |||
| } | |||
|
|
|||
| shared_ptr<BlockHandle> BlockManager::RegisterMetaBlock(block_id_t block_id) { | |||
| auto handle = RegisterBlock(block_id); | |||
| meta_blocks[block_id] = handle; | |||
There was a problem hiding this comment.
This cache will always persist - perhaps we should clear it after the metadata is read (by calling meta_blocks.clear() after the initial load of a database is completed)?
Thanks for the comments! Some modifications are made:
|
|
Thanks! |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fix #5698
A map from
block_idtoshared_ptr<BlockHandle>can be maintained byBlockManager, making theBlockHandleof meta blocks not freed even whenMetaBlockReaderis freed.To recover a TPC-H(SF=100) checkpoint (27GB), the running time of function
SingleFileStorageManager::LoadDatabase:There is a speedup of more than 10x. (Note that this experiment is performed when direct_io=false. For direct_io=true, there will be a much greater improvement.)