docs: add nodejs connection args to docs #5780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tshauck
changed the title
|
Doesn't look like this quite did what you intended - you can see the output here: https://github.com/duckdb/duckdb/actions/runs/3768815794 |
|
Thanks @Mause ... could you say what it should be?... E.g. this is what I added...
then when I look at similar examples, I see...
which makes me think it did? |
|
@Mause Thought I'd check in to ask for a hint before closing this (or just lmk if I should close anyways), thanks! |
Oops sorry you are quite correct, I was expecting to see a new entry in the TOC. Any chance you could fix up the config/access_mode? Pretty sure you can only provide one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asked the question here wondering how to pass a config to the nodejs database constructor since I couldn't find it in the docs. This PR is an attempt to add that info to the docs.