New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Julia] Use best practices for locking strategies #5905

Merged

Mytherin merged 1 commit into duckdb:master from Tishj:julia_locking_best_practices

Jan 13, 2023

Contributor

Tishj commented Jan 13, 2023

This PR changes the way we use locks in our Julia client to best practices as recommended in https://docs.julialang.org/en/v1/manual/multi-threading/#Data-race-freedom


          use try-finally for locking

92280f7

Mytherin merged commit fc2ef03 into duckdb:master

kpamnany reviewed

View reviewed changes

tools/juliapkg/src/table_function.jl

Comment on lines +51 to +58

+                  begin
+                      lock(main_function.global_lock)
+                      try
+                          push!(main_function.global_objects, object)
+                      finally
+                          unlock(main_function.global_lock)
+                      end
+                  end

kpamnany Jan 13, 2023

This is more compact?

lock(main_function.global_lock) do
    push!(main_function.global_objects, object)
end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment