Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing Arrow ABI Testing #5980

Merged
merged 2 commits into from
Jan 25, 2023
Merged

Removing Arrow ABI Testing #5980

merged 2 commits into from
Jan 25, 2023

Conversation

pdet
Copy link
Contributor

@pdet pdet commented Jan 24, 2023

It appears that these old tests are no longer necessary as they have been replaced by a newer test in test/arrow_roundtrip/arrow_roundtrip.cpp. The new tests are also a better option as they do not require Arrow as a dependency.

@Mytherin Mytherin linked an issue Jan 24, 2023 that may be closed by this pull request
2 tasks
Copy link
Collaborator

@Mytherin Mytherin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@Mytherin Mytherin merged commit 47ba19a into duckdb:master Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restore support for BUILD_ARROW_ABI_TEST
2 participants