Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix amalgamation build: returning (std::)move will otherwise be flagg… #5991

Merged
merged 2 commits into from
Jan 26, 2023

Conversation

carlopi
Copy link
Contributor

@carlopi carlopi commented Jan 25, 2023

…ed as not required

Probably there is a better / more general solution to this, since I expect it will pop-up also in other places

…ed as not required

Probably there is a better / more general solution to this, since I expect it will pop-up also in other places
@carlopi carlopi added bug and removed bug labels Jan 25, 2023
@Mytherin
Copy link
Collaborator

Mytherin commented Jan 25, 2023

Is this not related to #2866? Will these changes not break GCC-4.8? Perhaps you could verify this on your fork CI first.

@carlopi
Copy link
Contributor Author

carlopi commented Jan 25, 2023

Is this not related to #2866? Will these changes not break GCC-4.8? Perhaps you could verify this on your fork CI first.

Yes, it is related, I will give it a read to check the reasoning.
I think possibly it should be fine (now, I did run into GCC-4.8 / rasperry pi in a previous version), since we explicitly re-create the unique_ptr<> with the right type, and I think it should work on the CI (but then there was a second hidden issue, this one easier to fix since types are the same).

@carlopi carlopi mentioned this pull request Jan 26, 2023
@Mytherin Mytherin merged commit db526dc into duckdb:master Jan 26, 2023
@Mytherin
Copy link
Collaborator

Thanks! Seems like it passes the CI.

@carlopi carlopi deleted the unique_ptr_cast branch February 7, 2023 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants