Rcpp17 #6022
Merged
Rcpp17 #6022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is currently an issue with that test, skipping it using a shortcut of requiring an extension that will not be found at testing-time.
|
Thanks! |
Merged
|
This might hurt R 3.6.0 and R 4.0.0. |
Could you elaborate on this + what you would suggest? |
|
To be more precise, not hurting old R versions, but old OSes and compilers that don't support C++17. So, unless we need it, it seems better to require C++11 and not mention it, as in my other PR. |
|
Understood. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapt to CRAN's "NOTE: Specified C++11: please update to current default of C++17"
Note that we are disabling a test, to be worked on independently from this.