Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dev] Fix #6020: Fix failure of CI with pyarrow #6023

Merged
merged 1 commit into from
Jan 28, 2023

Conversation

papparapa
Copy link
Contributor

@papparapa papparapa commented Jan 28, 2023

Fixes #6020

pyarrow 11.0.0 got released on January 27, 2023.
In pyarrow 10.0.1, from_batches function took schama argument as positional or keyword argument, but in 11.0.0, it takes schama only as keyword argument.

apache/arrow@apache-arrow-10.0.1...apache-arrow-11.0.0#diff-704d642afd62c0e9577833149c45e3c9df38a31fc0f478eee5b68b359a9075baL2529-R2690

https://github.com/apache/arrow/blob/f10f5cfd1376fb0e602334588b3f3624d41dee7d/python/pyarrow/_dataset.pyx#L2686-L2690

This PR makes calling from_batches to use keyword argument schama.

@papparapa papparapa changed the title [Dev] Fix #6020: Fix CI with pyarrow failure [Dev] Fix #6020: Fix failure of CI with pyarrow Jan 28, 2023
@Mytherin Mytherin merged commit 8281080 into duckdb:master Jan 28, 2023
@Mytherin
Copy link
Collaborator

Thanks!

@papparapa papparapa deleted the fix-ci-with-pyarrow-failure branch January 28, 2023 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Dev] CI with pyarrow failed
2 participants