Ccaching2 #6101
Merged
Ccaching2 #6101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Currently (Jan '23) cache dimension is regularly bigger than the max of 10 GB, so consequently stuff gets evicted -> cache misses -> higher build times. Limiting caching on the main repo to 'master' allows to keep every workflow in the cache, while pull requests can default to the ccache for master (that's not optimal, but outweighted by less cache misses)
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #5999 with minor improvements and without re-enablig MacOs tests for PRs.
Effect of this should be reducing build time, both because caching it's used in more places AND because cache hits should increase (by effect of keeping artifacts only for main branch, with PRs falling back to main branch cache). Idea here is that a slighly different cache is better than a cache miss, and we were regularly over quota.
It has no functional changes to any duckdb components or deployment, only to caching strategy.