Try to auto-cast list_filter input and throw exception when failing #6119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mytherin
reviewed
Feb 7, 2023
There was a problem hiding this comment.
Thanks for the PR!
I wonder if this cannot be solved at binding time by forcing the return type of the expression to be boolean. For regular functions this is solved by setting the arguments types - but perhaps for lambdas we need to explicitly call BoundCastExpression::AddCastToType to add the cast to the expression.
Mytherin
reviewed
Feb 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses one of the two bugs mentioned in #5816.
list_filterwould throw a runtime error when provided with non-boolean lambda expression results in nested lambdas. Now, we try to auto-cast the expression result tobool, and throw an exception if that fails.